[pp/XAttrMetadata] Try to write each attribute (#11115)

Authored by: eric321
This commit is contained in:
Eric Lammerts 2024-10-07 19:17:55 -04:00 committed by GitHub
parent de2062753a
commit 3a193346ee
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -26,38 +26,40 @@ class XAttrMetadataPP(PostProcessor):
XATTR_MAPPING = { XATTR_MAPPING = {
'user.xdg.referrer.url': 'webpage_url', 'user.xdg.referrer.url': 'webpage_url',
# 'user.xdg.comment': 'description',
'user.dublincore.title': 'title', 'user.dublincore.title': 'title',
'user.dublincore.date': 'upload_date', 'user.dublincore.date': 'upload_date',
'user.dublincore.description': 'description',
'user.dublincore.contributor': 'uploader', 'user.dublincore.contributor': 'uploader',
'user.dublincore.format': 'format', 'user.dublincore.format': 'format',
# We do this last because it may get us close to the xattr limits
# (e.g., 4kB on ext4), and we don't want to have the other ones fail
'user.dublincore.description': 'description',
# 'user.xdg.comment': 'description',
} }
def run(self, info): def run(self, info):
mtime = os.stat(info['filepath']).st_mtime mtime = os.stat(info['filepath']).st_mtime
self.to_screen('Writing metadata to file\'s xattrs') self.to_screen('Writing metadata to file\'s xattrs')
try: for xattrname, infoname in self.XATTR_MAPPING.items():
for xattrname, infoname in self.XATTR_MAPPING.items(): try:
value = info.get(infoname) value = info.get(infoname)
if value: if value:
if infoname == 'upload_date': if infoname == 'upload_date':
value = hyphenate_date(value) value = hyphenate_date(value)
write_xattr(info['filepath'], xattrname, value.encode()) write_xattr(info['filepath'], xattrname, value.encode())
except XAttrUnavailableError as e: except XAttrUnavailableError as e:
raise PostProcessingError(str(e)) raise PostProcessingError(str(e))
except XAttrMetadataError as e: except XAttrMetadataError as e:
if e.reason == 'NO_SPACE': if e.reason == 'NO_SPACE':
self.report_warning( self.report_warning(
'There\'s no disk space left, disk quota exceeded or filesystem xattr limit exceeded. ' 'There\'s no disk space left, disk quota exceeded or filesystem xattr limit exceeded. '
'Some extended attributes are not written') f'Extended attribute "{xattrname}" was not written.')
elif e.reason == 'VALUE_TOO_LONG': elif e.reason == 'VALUE_TOO_LONG':
self.report_warning('Unable to write extended attributes due to too long values.') self.report_warning(f'Unable to write extended attribute "{xattrname}" due to too long values.')
else: else:
tip = ('You need to use NTFS' if compat_os_name == 'nt' tip = ('You need to use NTFS' if compat_os_name == 'nt'
else 'You may have to enable them in your "/etc/fstab"') else 'You may have to enable them in your "/etc/fstab"')
raise PostProcessingError(f'This filesystem doesn\'t support extended attributes. {tip}') raise PostProcessingError(f'This filesystem doesn\'t support extended attributes. {tip}')
self.try_utime(info['filepath'], mtime, mtime) self.try_utime(info['filepath'], mtime, mtime)
return [], info return [], info