From 220ee33f2b8a22d2fe992c26b32a046b77ce2a4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sergey=20M=E2=80=A4?= Date: Fri, 22 Jan 2016 22:23:21 +0600 Subject: [PATCH] [cbsnews] Simplify subtitles extraction and fix test (Closes #8295) --- youtube_dl/extractor/cbsnews.py | 33 ++++++++++----------------------- 1 file changed, 10 insertions(+), 23 deletions(-) diff --git a/youtube_dl/extractor/cbsnews.py b/youtube_dl/extractor/cbsnews.py index 7b9dd67fd6..480435e261 100644 --- a/youtube_dl/extractor/cbsnews.py +++ b/youtube_dl/extractor/cbsnews.py @@ -35,21 +35,11 @@ class CBSNewsIE(InfoExtractor): 'title': 'Fort Hood shooting: Army downplays mental illness as cause of attack', 'thumbnail': 're:^https?://.*\.jpg$', 'duration': 205, - }, - 'params': { - # rtmp download - 'skip_download': True, - }, - }, - { - 'url': 'http://www.cbsnews.com/videos/mountain-lions-of-l-a/', - 'info_dict': { - 'id': 'Mountain Lions of L.A.', - 'ext': 'flv', - 'title': 'Fort Hood shooting: Army downplays mental illness as cause of attack', - 'thumbnail': 're:^http?://.*\.jpg$', - 'subtitles': 're:^http?://.*\.xml$', - 'duration': 787, + 'subtitles': { + 'en': [{ + 'ext': 'ttml', + }], + }, }, 'params': { # rtmp download @@ -100,15 +90,12 @@ def _real_extract(self, url): fmt['ext'] = 'mp4' formats.append(fmt) + subtitles = {} if 'mpxRefId' in video_info: - cap_url = 'http://www.cbsnews.com/videos/captions/%s.adb_xml' % video_info['mpxRefId'] - subtitles = { - 'en': [{ - 'url': cap_url, - 'ext': 'xml' - }], } - else: - subtitles = {} + subtitles['en'] = [{ + 'ext': 'ttml', + 'url': 'http://www.cbsnews.com/videos/captions/%s.adb_xml' % video_info['mpxRefId'], + }] return { 'id': video_id,