From 869950690d6c20eb5bf1d784ea74807d60d399cd Mon Sep 17 00:00:00 2001 From: Roland Hieber Date: Sun, 6 Oct 2024 20:07:06 +0200 Subject: [PATCH 1/2] PBS: fix tests First URL is no longer available. Fix info dict for the second test. --- yt_dlp/extractor/pbs.py | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/yt_dlp/extractor/pbs.py b/yt_dlp/extractor/pbs.py index 686796491d..77994b7fe9 100644 --- a/yt_dlp/extractor/pbs.py +++ b/yt_dlp/extractor/pbs.py @@ -197,26 +197,25 @@ class PBSIE(InfoExtractor): _GEO_COUNTRIES = ['US'] _TESTS = [ - { - 'url': 'http://www.pbs.org/tpt/constitution-usa-peter-sagal/watch/a-more-perfect-union/', - 'md5': '173dc391afd361fa72eab5d3d918968d', - 'info_dict': { - 'id': '2365006249', - 'ext': 'mp4', - 'title': 'Constitution USA with Peter Sagal - A More Perfect Union', - 'description': 'md5:31b664af3c65fd07fa460d306b837d00', - 'duration': 3190, - }, - }, { 'url': 'http://www.pbs.org/wgbh/pages/frontline/losing-iraq/', - 'md5': '6f722cb3c3982186d34b0f13374499c7', + 'md5': '372b12b670070de39438b946474df92f', 'info_dict': { 'id': '2365297690', 'ext': 'mp4', 'title': 'FRONTLINE - Losing Iraq', 'description': 'md5:5979a4d069b157f622d02bff62fbe654', 'duration': 5050, + 'chapters': [ + {'start_time': 0.0, 'end_time': 1234.0, 'title': 'After Saddam, Chaos'}, + {'start_time': 1233.0, 'end_time': 1719.0, 'title': 'The Insurgency Takes Root'}, + {'start_time': 1718.0, 'end_time': 2461.0, 'title': 'A Light Footprint'}, + {'start_time': 2460.0, 'end_time': 3589.0, 'title': 'The Surge '}, + {'start_time': 3588.0, 'end_time': 4355.0, 'title': 'The Withdrawal '}, + {'start_time': 4354.0, 'end_time': 5051.0, 'title': 'ISIS on the March '}, + ], + 'display_id': 'losing-iraq', + 'thumbnail': 'https://image.pbs.org/video-assets/pbs/frontline/138098/images/mezzanine_401.jpg', }, }, { From 1e7153125b0f767b07b75aa8d0b7134c1a23b247 Mon Sep 17 00:00:00 2001 From: Roland Hieber Date: Sun, 6 Oct 2024 21:11:14 +0200 Subject: [PATCH 2/2] PBS: make thirteen.org work --- yt_dlp/extractor/pbs.py | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/yt_dlp/extractor/pbs.py b/yt_dlp/extractor/pbs.py index 77994b7fe9..b772f98718 100644 --- a/yt_dlp/extractor/pbs.py +++ b/yt_dlp/extractor/pbs.py @@ -188,7 +188,7 @@ class PBSIE(InfoExtractor): # Direct video URL (?:{})/(?:(?:vir|port)alplayer|video)/(?P[0-9]+)(?:[?/]|$) | # Article with embedded player (or direct video) - (?:www\.)?pbs\.org/(?:[^/]+/){{1,5}}(?P[^/]+?)(?:\.html)?/?(?:$|[?\#]) | + (?:www\.)?(thirteen|pbs)\.org/(?:[^/]+/){{1,5}}(?P[^/]+?)(?:\.html)?/?(?:$|[?\#]) | # Player (?:video|player)\.pbs\.org/(?:widget/)?partnerplayer/(?P[^/]+) ) @@ -197,6 +197,19 @@ class PBSIE(InfoExtractor): _GEO_COUNTRIES = ['US'] _TESTS = [ + { + 'url': 'https://www.thirteen.org/programs/the-woodwrights-shop/carving-away-with-mary-may-tioglz/', + 'info_dict': { + 'id': '3004803331', + 'ext': 'mp4', + 'title': "The Woodwright's Shop - Carving Away with Mary May", + 'description': 'md5:7cbaaaa8b9bcc78bd8f0e31911644e28', + 'duration': 1606, + 'display_id': 'carving-away-with-mary-may-tioglz', + 'chapters': [], + 'thumbnail': 'https://image.pbs.org/video-assets/NcnTxNl-asset-mezzanine-16x9-K0Keoyv.jpg', + }, + }, { 'url': 'http://www.pbs.org/wgbh/pages/frontline/losing-iraq/', 'md5': '372b12b670070de39438b946474df92f', @@ -214,8 +227,8 @@ class PBSIE(InfoExtractor): {'start_time': 3588.0, 'end_time': 4355.0, 'title': 'The Withdrawal '}, {'start_time': 4354.0, 'end_time': 5051.0, 'title': 'ISIS on the March '}, ], - 'display_id': 'losing-iraq', - 'thumbnail': 'https://image.pbs.org/video-assets/pbs/frontline/138098/images/mezzanine_401.jpg', + 'display_id': 'losing-iraq', + 'thumbnail': 'https://image.pbs.org/video-assets/pbs/frontline/138098/images/mezzanine_401.jpg', }, }, { @@ -462,6 +475,7 @@ def _extract_webpage(self, url): r"div\s*:\s*'videoembed'\s*,\s*mediaid\s*:\s*'(\d+)'", # frontline video embed r'class="coveplayerid">([^<]+)<', # coveplayer r']+data-coveid="(\d+)"', # coveplayer from http://www.pbs.org/wgbh/frontline/film/real-csi/ + r'.*class="passportcoveplayer"[^>]+data-media="(\d+)', # https://www.thirteen.org/programs/the-woodwrights-shop/who-wrote-the-book-of-sloyd-fggvvq/ r'', # jwplayer r"(?s)window\.PBS\.playerConfig\s*=\s*{.*?id\s*:\s*'([0-9]+)',", r']+\bdata-cove-id=["\'](\d+)"', # http://www.pbs.org/wgbh/roadshow/watch/episode/2105-indianapolis-hour-2/