From fbd722538651bbb06271306cf58909c420e2f155 Mon Sep 17 00:00:00 2001
From: Peter Osterlund <peterosterlund2@gmail.com>
Date: Sat, 14 Apr 2012 13:25:19 +0000
Subject: [PATCH] DroidFish: Made "save to pgn file" easier to understand.

---
 DroidFish/res/layout/select_game.xml                      | 6 ++++++
 DroidFish/res/values/strings.xml                          | 3 ++-
 DroidFish/src/org/petero/droidfish/DroidFish.java         | 1 -
 .../src/org/petero/droidfish/activities/EditPGN.java      | 8 ++++++++
 4 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/DroidFish/res/layout/select_game.xml b/DroidFish/res/layout/select_game.xml
index 0c779c4..97e6f3d 100644
--- a/DroidFish/res/layout/select_game.xml
+++ b/DroidFish/res/layout/select_game.xml
@@ -4,6 +4,12 @@
   android:layout_width="fill_parent"
   android:layout_height="fill_parent"
   android:orientation="vertical">
+  <TextView
+      android:id="@+id/select_game_hint"
+      android:layout_width="fill_parent"
+      android:layout_height="wrap_content"
+      android:includeFontPadding="true">
+  </TextView>
   <EditText
   	android:id="@+id/select_game_filter"
   	android:hint="@string/filter_text"
diff --git a/DroidFish/res/values/strings.xml b/DroidFish/res/values/strings.xml
index 5de412c..41b0b70 100644
--- a/DroidFish/res/values/strings.xml
+++ b/DroidFish/res/values/strings.xml
@@ -269,7 +269,7 @@ you are not actively using the program.\
     <string name="filename">Filename:</string>
     <string name="halfmove">Halfmove clock:</string>
     <string name="fullmove">Fullmove counter:</string>
-    <string name="filter_text">Filter text</string>
+    <string name="filter_text">Search…</string>
     <string name="value_percent">Value (%):</string>
     <string name="header_event">Event:</string>
     <string name="header_site">Site:</string>
@@ -299,6 +299,7 @@ you are not actively using the program.\
     <string name="preferences">Preferences</string>
     <string name="load_game_title">Edit File / Load Game</string>
     <string name="save_game_title">Edit File / Save Game</string>
+    <string name="save_game_hint">Select an existing game to control where to save the game. Long press an existing game to delete it.</string>
     <string name="load_scid_game_title">Load Scid Game</string>
     <string name="cpu_warning_title">CPU Warning</string>
     <string name="failed_to_read_pgn_data">Failed to read pgn data</string>
diff --git a/DroidFish/src/org/petero/droidfish/DroidFish.java b/DroidFish/src/org/petero/droidfish/DroidFish.java
index 8b73c8f..c8c1c08 100644
--- a/DroidFish/src/org/petero/droidfish/DroidFish.java
+++ b/DroidFish/src/org/petero/droidfish/DroidFish.java
@@ -141,7 +141,6 @@ public class DroidFish extends Activity implements GUIInterface {
 
     // FIXME!!! Option to display coordinates in border outside chess board.
     // FIXME!!! Hard to understand how to undo a single half-move.
-    // FIXME!!! Hard to understand how "save game" works.
 
     // FIXME!!! Better behavior if engine is terminated. How exactly?
     // FIXME!!! Handle PGN intents with more than one game.
diff --git a/DroidFish/src/org/petero/droidfish/activities/EditPGN.java b/DroidFish/src/org/petero/droidfish/activities/EditPGN.java
index d9027c9..8872148 100644
--- a/DroidFish/src/org/petero/droidfish/activities/EditPGN.java
+++ b/DroidFish/src/org/petero/droidfish/activities/EditPGN.java
@@ -47,6 +47,7 @@ import android.widget.AdapterView;
 import android.widget.ArrayAdapter;
 import android.widget.EditText;
 import android.widget.ListView;
+import android.widget.TextView;
 import android.widget.Toast;
 import android.widget.AdapterView.OnItemClickListener;
 import android.widget.AdapterView.OnItemLongClickListener;
@@ -58,6 +59,7 @@ public class EditPGN extends ListActivity {
     ProgressDialog progress;
     private GameInfo selectedGi = null;
     ArrayAdapter<GameInfo> aa = null;
+    TextView hintText = null;
     EditText filterText = null;
 
     SharedPreferences settings;
@@ -278,6 +280,12 @@ public class EditPGN extends ListActivity {
             }
         });
         filterText.setText(lastSearchString);
+        hintText = (TextView)findViewById(R.id.select_game_hint);
+        if (loadGame) {
+            hintText.setVisibility(View.GONE);
+        } else {
+            hintText.setText(R.string.save_game_hint);
+        }
         lv.requestFocus();
     }