From c5873310c6273cc71dd97d87c4b997d741ffbedd Mon Sep 17 00:00:00 2001 From: Ivan Alejandro Date: Sat, 13 Jun 2015 22:53:22 -0300 Subject: [PATCH] use node base image and improve build time/space - Use node base image, this simplify the Dockerfile, ease the update for node stuff. - Flatten images to decrease layers' size - Do a shallow clone to speedup build time --- atom/Dockerfile | 36 +++++++++++++++--------------------- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/atom/Dockerfile b/atom/Dockerfile index 014ed06..c459ec1 100644 --- a/atom/Dockerfile +++ b/atom/Dockerfile @@ -20,32 +20,26 @@ # # Base docker image -FROM debian:jessie +FROM node MAINTAINER Jessica Frazelle # Install dependencies -RUN apt-get update && apt-get install -y \ - build-essential \ - ca-certificates \ - curl \ - git \ - libasound2 \ - libgconf-2-4 \ - libgnome-keyring-dev \ - libgtk2.0-0 \ - libnss3 \ - libxtst6 \ - --no-install-recommends +RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \ + libasound2 \ + libgconf-2-4 \ + libgnome-keyring-dev \ + libgnome-keyring-dev \ + libgtk2.0-0 \ + libnss3 \ + libxtst6 && \ + apt-get clean && rm -rf /var/lib/apt/lists/* -# install node -RUN curl -sL https://deb.nodesource.com/setup | bash - -RUN apt-get install -y nodejs - -# clone atom -RUN git clone https://github.com/atom/atom /src WORKDIR /src -RUN git fetch && git checkout $(git describe --tags `git rev-list --tags --max-count=1`) -RUN script/build && script/grunt install + +RUN LATEST_TAG=`git ls-remote --tags https://github.com/atom/atom | sort -t '/' -k3 --version-sort | tail -n1 | cut -d'/' -f3` && \ + git clone -b $LATEST_TAG https://github.com/atom/atom --depth 1 /src && \ + script/build && script/grunt install && \ + rm -fr /src # Autorun atom CMD /usr/local/bin/atom --foreground --log-file /var/log/atom.log && tail -f /var/log/atom.log